Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): substitute kuttl to bash e2e test #411

Merged
merged 6 commits into from
Mar 23, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Mar 22, 2023

This PR

adds two e2e tests:

  • one to check if flagd is injected and if the flags are available
  • the other checks if we do not inject flagd in case the deployment has it disabled

Related Issues

Fixes #391

Notes

should we get rid of the scripts after migration?

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #411 (dd5182a) into main (2a86b03) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   71.31%   71.31%           
=======================================
  Files          11       11           
  Lines         847      847           
=======================================
  Hits          604      604           
  Misses        215      215           
  Partials       28       28           
Flag Coverage Δ
component-tests 65.04% <ø> (ø)
unit-tests 20.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@skyerus skyerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the accidental check in, nice :)

config/manager/kustomization.yaml Outdated Show resolved Hide resolved
@RealAnna RealAnna requested a review from skyerus March 23, 2023 13:39
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
@toddbaert toddbaert merged commit ff199f1 into open-feature:main Mar 23, 2023
@odubajDT
Copy link
Contributor

part of #370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement e2e tests in OF operator using KUTTL
5 participants