-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): substitute kuttl to bash e2e test #411
Merged
toddbaert
merged 6 commits into
open-feature:main
from
RealAnna:chore/refactor_pod_mutator
Mar 23, 2023
Merged
feat(test): substitute kuttl to bash e2e test #411
toddbaert
merged 6 commits into
open-feature:main
from
RealAnna:chore/refactor_pod_mutator
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
421a592
to
e3ddbe4
Compare
Codecov Report
@@ Coverage Diff @@
## main #411 +/- ##
=======================================
Coverage 71.31% 71.31%
=======================================
Files 11 11
Lines 847 847
=======================================
Hits 604 604
Misses 215 215
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. |
skyerus
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the accidental check in, nice :)
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
6bb1fff
to
dd5182a
Compare
skyerus
approved these changes
Mar 23, 2023
james-milligan
approved these changes
Mar 23, 2023
part of #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
adds two e2e tests:
Related Issues
Fixes #391
Notes
should we get rid of the scripts after migration?