Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add unit tests to pod webhook #419

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Mar 27, 2023

This PR

  • removes bug from annotation filter
  • adds unit tests to admission webhook
  • moved component test to a different file, put unit test in pod_webhook_test.go

Related Issues

#394

@RealAnna RealAnna requested a review from a team as a code owner March 27, 2023 13:21
@RealAnna RealAnna marked this pull request as draft March 27, 2023 13:25
@RealAnna RealAnna force-pushed the chore/add_unit_tests_to_webhook branch from 2f58dd7 to 3fdde5c Compare March 27, 2023 13:31
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #419 (5f847d1) into main (8624958) will increase coverage by 44.48%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #419       +/-   ##
===========================================
+ Coverage   36.25%   80.74%   +44.48%     
===========================================
  Files          12       12               
  Lines         855      857        +2     
===========================================
+ Hits          310      692      +382     
+ Misses        530      136      -394     
- Partials       15       29       +14     
Impacted Files Coverage Δ
webhooks/pod_webhook.go 89.22% <100.00%> (+89.22%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
component-tests 84.86% <100.00%> (?)
unit-tests 56.24% <100.00%> (+19.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna marked this pull request as ready for review March 27, 2023 13:37
@toddbaert toddbaert self-requested a review March 27, 2023 19:14
RealAnna and others added 3 commits March 28, 2023 07:38
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@RealAnna RealAnna force-pushed the chore/add_unit_tests_to_webhook branch from 4ee6747 to 6702c89 Compare March 28, 2023 05:38
Signed-off-by: realanna <anna.reale@dynatrace.com>
@beeme1mr beeme1mr self-requested a review March 28, 2023 12:40
@beeme1mr beeme1mr merged commit 4290978 into open-feature:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants