Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce additional unit tests for api packages #420

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 27, 2023

This PR

  • refactor api packages
  • cover api packages by unit tests
  • adapt changes

Related Issues

Fixes #394

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #420 (0d71726) into main (4290978) will increase coverage by 28.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #420       +/-   ##
===========================================
+ Coverage   56.24%   84.26%   +28.01%     
===========================================
  Files          12       19        +7     
  Lines         857     1061      +204     
===========================================
+ Hits          482      894      +412     
+ Misses        356      138      -218     
- Partials       19       29       +10     
Impacted Files Coverage Δ
...is/core/v1alpha2/featureflagconfiguration_types.go 50.00% <ø> (+33.33%) ⬆️
...is/core/v1alpha1/featureflagconfiguration_types.go 100.00% <100.00%> (ø)
...pis/core/v1alpha1/flagsourceconfiguration_types.go 100.00% <100.00%> (ø)
...ollers/core/featureflagconfiguration/controller.go 54.63% <100.00%> (ø)
pkg/utils/utils.go 100.00% <100.00%> (ø)
webhooks/pod_webhook.go 89.22% <100.00%> (+46.11%) ⬆️

... and 6 files with indirect coverage changes

Flag Coverage Δ
component-tests 84.86% <100.00%> (?)
unit-tests 64.46% <87.50%> (+8.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT changed the title chore: refactor apis + introduce additional unit tests chore: introduce additional unit tests for api packages Mar 27, 2023
@odubajDT odubajDT marked this pull request as ready for review March 27, 2023 13:39
@odubajDT odubajDT requested a review from a team as a code owner March 27, 2023 13:40
@toddbaert toddbaert self-requested a review March 28, 2023 18:05
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@james-milligan james-milligan merged commit 5ba5bc9 into open-feature:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Unit tests for Controllers using K8s Fake Client
5 participants