-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactored component test using fake client #435
Conversation
Codecov Report
@@ Coverage Diff @@
## main #435 +/- ##
==========================================
- Coverage 79.13% 78.00% -1.14%
==========================================
Files 21 21
Lines 1323 1323
==========================================
- Hits 1047 1032 -15
- Misses 234 251 +17
+ Partials 42 40 -2 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice work! :)
9735881
to
671792a
Compare
…ditions Signed-off-by: realanna <anna.reale@dynatrace.com> refactor: fixed silly unit test Signed-off-by: realanna <anna.reale@dynatrace.com> refactor: remove redundant component test pipeline Signed-off-by: realanna <anna.reale@dynatrace.com> refactor: rewrote component tests using fake client to avoid race conditions Signed-off-by: realanna <anna.reale@dynatrace.com> chore: converted ginko tests Signed-off-by: realanna <anna.reale@dynatrace.com> chore: converted ginko tests Signed-off-by: realanna <anna.reale@dynatrace.com> chore: added a test Signed-off-by: realanna <anna.reale@dynatrace.com> chore: added a test Signed-off-by: realanna <anna.reale@dynatrace.com>
671792a
to
57839a9
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woohoo! this is great! A whole job gone from CI. Thanks a lot for this @RealAnna . I guess these are much faster too with the fake.client.
I looked through all the changes, and nothing seemed out of order.
This PR