Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update flagd proxy env var prefix #440

Merged

Conversation

james-milligan
Copy link
Contributor

This PR

  • updates env var prefix from KUBE_PROXY_ to FLAGD_PROXY_

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan james-milligan requested a review from a team as a code owner April 3, 2023 13:57
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #440 (c1d090c) into main (08a50ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files          21       21           
  Lines        1323     1323           
=======================================
  Hits         1032     1032           
  Misses        251      251           
  Partials       40       40           
Impacted Files Coverage Δ
...rollers/core/flagsourceconfiguration/controller.go 46.37% <ø> (ø)
Flag Coverage Δ
unit-tests 78.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@james-milligan james-milligan merged commit b451d47 into open-feature:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants