Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flagd proxy resource ownership #442

Merged
merged 21 commits into from
Apr 12, 2023

Conversation

james-milligan
Copy link
Contributor

This PR

  • configures the operator as the resource owner for the flagd proxy deployment
  • clean up of mismatched doc reference (kube-flagd-proxy > flags-proxy)

Related Issues

Notes

Follow-up Tasks

How to test

Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@james-milligan james-milligan requested a review from a team as a code owner April 4, 2023 10:18
Signed-off-by: James Milligan <james@omnant.co.uk>
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #442 (2dccb4d) into main (4cbe4f1) will decrease coverage by 0.36%.
The diff coverage is 74.28%.

@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   78.38%   78.02%   -0.36%     
==========================================
  Files          21       21              
  Lines        1346     1365      +19     
==========================================
+ Hits         1055     1065      +10     
- Misses        251      259       +8     
- Partials       40       41       +1     
Impacted Files Coverage Δ
...rollers/core/flagsourceconfiguration/controller.go 46.37% <0.00%> (ø)
...ollers/core/flagsourceconfiguration/flagd-proxy.go 74.71% <74.71%> (ø)
Flag Coverage Δ
unit-tests 78.02% <74.28%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kavindu-Dodan Kavindu-Dodan self-requested a review April 11, 2023 21:22
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
@beeme1mr beeme1mr self-requested a review April 12, 2023 13:39
@beeme1mr beeme1mr merged commit 31b5f7b into open-feature:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants