Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unneeded OF namespace prefix from clusterrolebindings #453

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Apr 7, 2023

This PR

  • removes OF namespace prefix from clusterrolebindings -> this way kustomize kicks in and adds the prefix to the the resources

@odubajDT odubajDT requested a review from a team as a code owner April 7, 2023 10:31
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #453 (3c974a9) into main (26ae125) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   78.38%   78.38%           
=======================================
  Files          21       21           
  Lines        1346     1346           
=======================================
  Hits         1055     1055           
  Misses        251      251           
  Partials       40       40           
Flag Coverage Δ
unit-tests 78.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT changed the title fix: remove uneeded OF namespace prefix from clusterrolebindings fix: remove unneeded OF namespace prefix from clusterrolebindings Apr 7, 2023
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@toddbaert toddbaert merged commit b23edef into open-feature:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants