Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Docs improvements and possible bug #483

Closed
agardnerIT opened this issue May 5, 2023 · 2 comments · Fixed by #496
Closed

[DOCS] Docs improvements and possible bug #483

agardnerIT opened this issue May 5, 2023 · 2 comments · Fixed by #496

Comments

@agardnerIT
Copy link
Contributor

I was going end-to-end as a new user would.

  1. Start here: https://github.com/open-feature/open-feature-operator/blob/main/docs/installation.md
  2. The above page should link at the bottom to: https://github.com/open-feature/open-feature-operator/blob/main/docs/getting_started.md (otherwise I've installed but can't use)
  3. In my demo setup, I don't seem to need FlagSourceConfiguration so to avoid confusion, possibly move this elsewhere (or remove if it is legacy?)
  4. This code snippet references openfeature.dev/flagsourceconfiguration which I believe is a typo. Using this in my setup doesn't inject the sidecar. Instead I need to use openfeature.dev/featureflagconfiguration
@james-milligan
Copy link
Contributor

Hi @agardnerIT, I looked through the getting started guide and looks like there was a versioning issue with the example crd which I've fixed here. This does not resolve this issue however as it seems there is a wider docs issue.

Were you getting an error when deploying the FlagSourceConfiguration, it may be that the versioning issue fixed above was preventing the deployment of the resource, and as a result blocking pod deployment as the FlagSourceConfiguration defined in the openfeature.dev/flagsourceconfiguration could not be found, please let me know if this resolves the issue.

This code snippet references openfeature.dev/flagsourceconfiguration which I believe is a typo. Using this in my setup doesn't inject the sidecar. Instead I need to use openfeature.dev/featureflagconfiguration

Using the openfeature.dev/featureflagconfiguration annotation is deprecated. The configuration for the injected sidecar is defined using the FlagSourceConfiguration resource, which can reference a FeatureFlagConfiguration as one of its Sources, the docs for the FeatureFlagConfiguration spec can be found here.

flowchart TD
    A[Pod]-->|openfeature.dev/flagsourceconfiguration| B[FlagSourceConfiguration CR]--> |sources| C[FeatureFlagConfiguration]
    B[FlagSourceConfiguration CR]--> |sources| D[FeatureFlagConfiguration]
B[FlagSourceConfiguration CR]--> |sources| E[HTTP sync]
Loading

@Kavindu-Dodan
Copy link
Contributor

Thank you @james-milligan for the mermaid diagram. I added this to our documentation :)

@agardnerIT I think this PR fixed your concerns and documentation is now updated - #496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants