Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: generalize renovate configuration #495

Merged
merged 40 commits into from
Jul 6, 2023
Merged

chore: generalize renovate configuration #495

merged 40 commits into from
Jul 6, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Jun 27, 2023 •
edited
Loading

This PR

  • adjusts the renovate config to be far more general
  • removes most of the specific regex setups for specific code occurrences in favor of the more generalized regex
  • since renovate can't handle monorepo tags out of the box I had to add some special "rewrite" rules to get tags like flagd/flagd and flagd/flagd-proxy

Related Issues

Fixes #465

mowies added 30 commits June 27, 2023 10:13
@mowies
also include yml files
7310b58 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
remove helm values regex managers since renovate covers helm values b…
90787c0 
…y default

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
update renovate annotation to cover more kuttl files, remove specific…
6668d7d 
… kuttl regex managers

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
test out new config by reducing flagd version
62a5c1d 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
test out new config by reducing flagd version
35edb59 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try escaping some chars
03aed0b 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try simplifying the annotation comment
5193ca8 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix renovate regex manager, go back to bog annotation comment
b16cead 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try using github-tags datasource
fd9e2ee 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
reduce another version
4dc0986 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
adjust yet another file
acbc4c4 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try simpler versions
3f9816e 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try adding package rules to extract the version correctly
1d22248 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try removing one flagd
2b0d2aa 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try using github-tags datasource
5d3cb3d 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try adjusting extract version rules again
4d135bb 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try more after first working version
36e281b 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
debugging
f1dbef2 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try if flagd-proxy gets picked up
67a88cd 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try adding more matched packages to renovate config
ba8c0da 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
adjust files according to new config
4b5869d 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try more things
7b18bec 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try even more things
a2b5d18 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
try even more things
735cde4 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
revert back to the correct versions and dep names
4a37686 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
remove extractVersionTemplate from regex manager
f4dabc5 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
remove regex matchers for charts readme since they dont match anythin…
355995c 
…g anymore

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
generalize regex manager even more
4a8d821 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
move sections around
0f87b3b 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
simplify regex
d9a1ed8 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies added 10 commits June 27, 2023 11:56
@mowies
use general approach also for go file to update flagd-proxy version
d6c0c1d 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix regex
7dcfb31 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
add go file to general manager
9f896af 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
use correct go file path
8c402ff 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
use correct go file path
da53b32 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix quotes in regex
426fcb9 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix quotes in regex
6d36af1 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
add flagsource config v1alpha1 to general regex manger
0d6e343 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
test new changes
97894a0 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
revert change after confirming that new config works
af880f5 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #495 (af880f5) into main (09dcbc1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files          22       22           
  Lines        1386     1386           
=======================================
  Hits         1144     1144           
  Misses        205      205           
  Partials       37       37
Impacted Files Coverage Δ
...pis/core/v1alpha1/flagsourceconfiguration_types.go 98.80% <ø> (ø)
controllers/common/flagd-proxy.go 82.18% <ø> (ø)
Flag Coverage Δ
unit-tests 82.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title Generalize renovate chore: generalize renovate configuration Jun 27, 2023
@mowies mowies marked this pull request as ready for review June 27, 2023 12:11
@mowies mowies requested a review from a team as a code owner June 27, 2023 12:11
Kavindu-Dodan
Kavindu-Dodan approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the comment on clarification

@thisthat thisthat merged commit 1ec3183 into open-feature:main Jul 6, 2023
@github-actions github-actions bot mentioned this pull request Jul 6, 2023
Merged
@mowies mowies deleted the generalize-renovate branch July 6, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-milligan james-milligan james-milligan approved these changes

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@thisthat thisthat thisthat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: refactor renovate.json to be more general
4 participants
@mowies @thisthat @Kavindu-Dodan @james-milligan