Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update K8s deps and fix api changes #518

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Aug 7, 2023

This PR

Update K8s dependencies & attempt to fix #515

Note

Unfortunately updating deps to v0.27.x variant failed as I encountered errors bumping controller-runtime to v0.15.x

See log below from the attempt

2023/08/07 18:54:08 http: panic serving 172.23.0.5:41558: runtime error: invalid memory address or nil pointer dereference
goroutine 182 [running]:
net/http.(*conn).serve.func1()
    /usr/local/go/src/net/http/server.go:1854 +0xb0
panic({0x1186200, 0x21924b0})
    /usr/local/go/src/runtime/panic.go:890 +0x248
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Decoder).DecodeRaw(0x0, {{0x4000492300, 0x2c9, 0x300}, {0x0, 0x0}}, {0x15d50f0, 0x4000485b80})
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.1/pkg/webhook/admission/decode.go:76 +0xec
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Decoder).Decode(_, {{{0x40005d55c0, 0x24}, {{0x40005fb710, 0x14}, {0x400012c4d0, 0x8}, {0x40005fb728, 0x18}}, {{0x40005fb740, ...}, ...}, ...}}, ...)
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.1/pkg/webhook/admission/decode.go:49 +0x74
github.com/open-feature/open-feature-operator/webhooks.(*FeatureFlagConfigurationValidator).Handle(_, {_, _}, {{{0x40005d55c0, 0x24}, {{0x40005fb710, 0x14}, {0x400012c4d0, 0x8}, {0x40005fb728, ...}}, ...}})
    /workspace/webhooks/featureflagconfiguration_webhook.go:36 +0x94
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).Handle(_, {_, _}, {{{0x40005d55c0, 0x24}, {{0x40005fb710, 0x14}, {0x400012c4d0, 0x8}, {0x40005fb728, ...}}, ...}})
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.1/pkg/webhook/admission/webhook.go:169 +0x180
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).ServeHTTP(0x400052c8c0, {0xffff9055f038?, 0x400052df90}, 0x400039c900)
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.1/pkg/webhook/admission/http.go:98 +0x994
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerInFlight.func1({0xffff9055f038, 0x400052df90}, 0x4000507e00?)
    /go/pkg/mod/github.com/prometheus/client_golang@v1.15.1/prometheus/promhttp/instrument_server.go:60 +0xb0
net/http.HandlerFunc.ServeHTTP(0x15e6530?, {0xffff9055f038?, 0x400052df90?}, 0x400055f818?)
    /usr/local/go/src/net/http/server.go:2122 +0x38
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerCounter.func1({0x15e6530?, 0x40004367e0?}, 0x400039c900)
    /go/pkg/mod/github.com/prometheus/client_golang@v1.15.1/prometheus/promhttp/instrument_server.go:147 +0xa0
net/http.HandlerFunc.ServeHTTP(0x400055fa58?, {0x15e6530?, 0x40004367e0?}, 0x40000f3db0?)
    /usr/local/go/src/net/http/server.go:2122 +0x38
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerDuration.func2({0x15e6530, 0x40004367e0}, 0x400039c900)
    /go/pkg/mod/github.com/prometheus/client_golang@v1.15.1/prometheus/promhttp/instrument_server.go:109 +0x94
net/http.HandlerFunc.ServeHTTP(0x40004367e0?, {0x15e6530?, 0x40004367e0?}, 0x373e28?)
    /usr/local/go/src/net/http/server.go:2122 +0x38
net/http.(*ServeMux).ServeHTTP(0x40000f3d91?, {0x15e6530, 0x40004367e0}, 0x400039c900)
    /usr/local/go/src/net/http/server.go:2500 +0x13c
net/http.serverHandler.ServeHTTP({0x15d8e80?}, {0x15e6530, 0x40004367e0}, 0x400039c900)
    /usr/local/go/src/net/http/server.go:2936 +0x2c0
net/http.(*conn).serve(0x4000581680, {0x15e7180, 0x40005982d0})
    /usr/local/go/src/net/http/server.go:1995 +0x518
created by net/http.(*Server).Serve
    /usr/local/go/src/net/http/server.go:3089 +0x4e8

@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner August 7, 2023 17:58
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #518 (1662c80) into main (22a1e55) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files          22       22           
  Lines        1423     1423           
=======================================
  Hits         1178     1178           
  Misses        207      207           
  Partials       38       38           
Flag Coverage Δ
unit-tests 82.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@beeme1mr beeme1mr merged commit 644144f into open-feature:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.2.35 panic: runtime error: invalid memory address or nil pointer dereference
2 participants