Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code and increase test coverage #533

Closed
12 of 13 tasks
Tracked by #528
odubajDT opened this issue Oct 24, 2023 · 0 comments · Fixed by #554
Closed
12 of 13 tasks
Tracked by #528

Refactor code and increase test coverage #533

odubajDT opened this issue Oct 24, 2023 · 0 comments · Fixed by #554
Assignees

Comments

@odubajDT
Copy link
Contributor

odubajDT commented Oct 24, 2023

Pre-requisites:

Goal

Clean up logic of packages in OFO

Details

There are multiple possibilities to improve the maintability of OFO logic, especially we are talking about the following:

  • polish controller logic; increase unit tests coverage
  • polish flagdproxy handler
  • polish flagdinjector
  • create global common package and move controllers/common into it
  • move pkg into global common package
  • polish and increase coverage of common package
  • polish and increase coverage of webhook package -> some functions can be moved to a local webhooks/common package for better readibility
  • remove all nolint comments (where it makes sense)

DoD

  • code is better structured and easier to read/understand
  • test coverage is increased in webhook and common packages

Notes

Some of the adjustments can be found in the PoC

@odubajDT odubajDT changed the title clean up code and improve code quality Refactor code and increase test coverage Oct 25, 2023
@odubajDT odubajDT self-assigned this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant