Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use v1beta1 API version #553

Merged
merged 5 commits into from
Nov 20, 2023
Merged

docs: use v1beta1 API version #553

merged 5 commits into from
Nov 20, 2023

Conversation

odubajDT
Copy link
Contributor

Fixes #534

@odubajDT
docs: use v1beta1
596aea8 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT requested a review from a team as a code owner November 17, 2023 16:46
StackScribe
StackScribe reviewed Nov 18, 2023
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Nov 18, 2023
View reviewed changes
docs/concepts.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Nov 18, 2023
View reviewed changes
docs/concepts.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Nov 18, 2023
View reviewed changes
docs/concepts.md Outdated Show resolved Hide resolved
@open-feature open-feature deleted a comment from StackScribe Nov 20, 2023
@odubajDT @StackScribe
Apply suggestions from code review
751b4dd 
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Merging #553 (5e68b6f) into main (233be79) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files          10       10           
  Lines         935      935           
=======================================
  Hits          788      788           
  Misses        121      121           
  Partials       26       26
Flag Coverage Δ
unit-tests 84.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT @StackScribe
Apply suggestions from code review
93d07d9 
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
toddbaert
toddbaert reviewed Nov 20, 2023
View reviewed changes
docs/feature_flag.md Outdated Show resolved Hide resolved
toddbaert
toddbaert reviewed Nov 20, 2023
View reviewed changes
docs/permissions.md Outdated Show resolved Hide resolved
toddbaert
toddbaert reviewed Nov 20, 2023
View reviewed changes
docs/quick_start.md Outdated Show resolved Hide resolved
toddbaert
toddbaert reviewed Nov 20, 2023
View reviewed changes
docs/concepts.md Outdated Show resolved Hide resolved
toddbaert
toddbaert reviewed Nov 20, 2023
View reviewed changes
docs/concepts.md Outdated Show resolved Hide resolved
@toddbaert toddbaert self-requested a review November 20, 2023 14:33
toddbaert
toddbaert approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a few small errors (wrong CRD mentioned), but approving pending those.

toddbaert and others added 2 commits November 20, 2023 09:34
@toddbaert
Merge branch 'main' into docs/534
b7e8e05
@odubajDT @toddbaert
Apply suggestions from code review
5e68b6f 
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@odubajDT odubajDT merged commit ccc0471 into open-feature:main Nov 20, 2023
11 checks passed
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
Merged
This was referenced Nov 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackScribe StackScribe StackScribe left review comments

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@toddbaert toddbaert toddbaert approved these changes

@beeme1mr beeme1mr Awaiting requested review from beeme1mr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt documentation to refer to v1beta1 API
4 participants
@odubajDT @StackScribe @Kavindu-Dodan @toddbaert