Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix file source documentation #556

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

Kavindu-Dodan
Copy link
Contributor

This PR

Fixes and improves file source documentation. Require merging prior to #545

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner November 28, 2023 23:32
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #556 (23d4337) into main (ccb8c1d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   87.91%   87.90%   -0.02%     
==========================================
  Files          10       10              
  Lines         927      926       -1     
==========================================
- Hits          815      814       -1     
  Misses         89       89              
  Partials       23       23              
Files Coverage Δ
apis/core/v1beta1/featureflagsource_types.go 96.59% <ø> (ø)
common/flagdinjector/flagdinjector.go 92.04% <100.00%> (-0.03%) ⬇️
Flag Coverage Δ
unit-tests 87.90% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@toddbaert toddbaert merged commit 318c52d into open-feature:main Nov 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants