Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flagd-proxy HA setup #609

Closed
xvzf opened this issue Feb 22, 2024 · 6 comments · Fixed by #712
Closed

flagd-proxy HA setup #609

xvzf opened this issue Feb 22, 2024 · 6 comments · Fixed by #712
Assignees

Comments

@xvzf
Copy link
Contributor

xvzf commented Feb 22, 2024

Based on the behaviour observed and the fixed replica count of 1 (ref), I'm wondering if it makes to have two or more instances of the flagd-proxy running in combination with a PodDisruptionBudget.

I can work on this (either as a config option or extending the schema similar to what's currently discussed in #524), but wanted to ask for feedback here first!

@toddbaert
Copy link
Member

@xvzf I like this idea. I think maybe we should default to 2 instances. I think an additional config option makes sense, but I'm interested in the opinions of others... @odubajDT @Kavindu-Dodan @thisthat what do you think?

It seems #524 is pretty stale, I'm going to close it.

@Kavindu-Dodan
Copy link
Contributor

We could do this through environment variables dedicated to proxy [1]. And regarding the need for replicas, I assume this is to provide HA for your use case and I think this is a good overal improvement.

[1] - https://github.com/open-feature/open-feature-operator/blob/main/docs/flagd_proxy.md#configuration

@thisthat
Copy link
Member

thisthat commented Feb 27, 2024

I think having HA for a central component like the proxy definitely makes sense 👍
I am wondering where we should allow this configuration 🤔 Currently, OFO creates the proxy as soon as it sees a FeatureFlagSource that has flagd-proxy as the provider. I think we should allow the three values to be configurable as EnvVar (with the Helm relative value entries): replica count, minAvailable, and maxUnavailable. This way, at startup OFO creates/updates the PodDisruptionBudget policy.

@xvzf
Copy link
Contributor Author

xvzf commented Mar 11, 2024

I'll come up with a draft PR in the next days :)

@toddbaert
Copy link
Member

Somebody mentioned this specific issue at KubeCon, so I guess you're right @xvzf

@xvzf
Copy link
Contributor Author

xvzf commented Oct 11, 2024

FYI picked this up now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants