fix: Add capability to skip crd installation during helm install #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estenrye
changed the title
estenrye
force-pushed
the
624-fix-skip-crds
branch
from
457f4bd
to
42c9dd3
Compare
|
@beeme1mr I ran the update script like the helm docs linter told me to. can you approve the workflows again? |
|
@beeme1mr I merged main into my branch since it was ahead of my branch, can you approve the workflow again? |
|
Hey @estenrye , I'll try and trigger the ci when I notice a change but feel free to ping me too. This is only an issue for first-time collaborators. Your next pr will be easier 🙂 |
thisthat
reviewed
Apr 24, 2024
thisthat
approved these changes
Apr 24, 2024
beeme1mr
approved these changes
Apr 24, 2024
Merged
Kavindu-Dodan
approved these changes
Apr 24, 2024
estenrye
force-pushed
the
624-fix-skip-crds
branch
2 times, most recently
from
4289a37
to
e642798
Compare
- Fixes open-feature#624 - add readme-generator-for-helm to .gitignore Signed-off-by: Esten Rye <esten.rye@ryezone.com>
estenrye
force-pushed
the
624-fix-skip-crds
branch
from
e642798
to
ea0828b
Compare
|
@beeme1mr can you re-run the workflows? I addressed PR feedback, rebased against main and squashed my commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Makefileto move CustomResourceDefinition templates to the crds directory before packaging the helm chart..gitignoreto ignore templates in thecrdsdirectory.--skip-crdsflag when performinghelm installRelated Issues
Fixes #624
Notes
Follow-up Tasks
How to test