-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use workspaces to make api changes easier #635
chore: use workspaces to make api changes easier #635
Conversation
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
One question: Is there any CI (particularly the release CI) that needs to be adapted for this to work? Do those flows need to init the workspace?
Looking at the CI I believe that the workspace might need to be initialised here:
although i'm not sure if the Edit: also I noticed the workspace init was missing before the test execution, so i have added it here as well |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Based on blame, it's been this way for 2 years: d4abda1 It seems like this is(was?) necessary before running |
Merging this now... we're releasing today so we'll know if it works 😅 |
Worked fine with the workspace init. I think we could move this into the makefile to make things more self-contained, but at least everything works as is. |
This PR introduces the use of go workspaces. Before this change, anything that involves a change or addition in the
apis
submodule required this to be split into multiple PRs (one for the api change, then a follow up to adapt the code in the controller/webhook). A similar approach is also used in https://github.com/open-feature/flagd, so I think we could also make use of that here