Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm sidecar resources not applied #639

Merged
merged 2 commits into from
May 15, 2024
Merged

fix: helm sidecar resources not applied #639

merged 2 commits into from
May 15, 2024

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented May 14, 2024 •
edited
Loading

We weren't correctly overlaying these in helm. I've added them similarly to others, using the same defaults from from here.

Fixes: #630

Manually tested and works as expected as well.

@toddbaert toddbaert requested a review from a team as a code owner May 14, 2024 21:37
Kavindu-Dodan
Kavindu-Dodan approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Basically we have two options to configure injected flagd's resource requests,

  1. From operator Helm (once this PR fix the bug)
  2. Through FeatureFlagSource resources where we can override this per deployment

I think we need to document these concepts :)

@toddbaert
fix: helm sidecar resources not applied
882c9e2 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert
fixup: helm docs
66a0827 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert force-pushed the fix/helm-sidecare-resources branch from 09f4e5a to 66a0827 Compare May 15, 2024 13:22
@toddbaert toddbaert mentioned this pull request May 15, 2024
Closed
@beeme1mr beeme1mr merged commit d549144 into main May 15, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Merged
@toddbaert toddbaert deleted the fix/helm-sidecare-resources branch May 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@thisthat thisthat thisthat approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sidecarConfiguration.resources in helm chart is ignored
5 participants
@toddbaert @beeme1mr @thisthat @Kavindu-Dodan @odubajDT