Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document new Flagd CRD #641

Merged
merged 4 commits into from
May 23, 2024
Merged

docs: document new Flagd CRD #641

merged 4 commits into from
May 23, 2024

Conversation

bacherfl
Copy link
Contributor

This PR documents the recently introduced Flagd CRD

@bacherfl
docs: document new Flagd CRD
6bfa8da 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl marked this pull request as ready for review May 22, 2024 08:48
@bacherfl bacherfl requested a review from a team as a code owner May 22, 2024 08:48
thisthat
thisthat reviewed May 22, 2024
View reviewed changes
docs/flagd.md Outdated Show resolved Hide resolved
thisthat
thisthat reviewed May 22, 2024
View reviewed changes
docs/flagd.md Outdated Show resolved Hide resolved
@bacherfl @thisthat
Apply suggestions from code review
4ae6cb4 
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
toddbaert
toddbaert reviewed May 22, 2024
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bacherfl this makes sense to me. I ran everything locally though and I was a bit suprised.... the version of flagd used by default is v0.9.0 (the SidecarTag) not the FlagdTag.

This causes some practical problems since 0.9.0 didn't support the sync or ofrep protocols. I can't immediately see why this seems to be happening.

version

@bacherfl
Copy link
Contributor Author

@bacherfl this makes sense to me. I ran everything locally though and I was a bit suprised.... the version of flagd used by default is v0.9.0 (the SidecarTag) not the FlagdTag.

This causes some practical problems since 0.9.0 didn't support the sync or ofrep protocols. I can't immediately see why this seems to be happening.

version version

thanks, I will look into this today

@thisthat
Copy link
Member

thisthat commented May 23, 2024 •
edited
Loading

@bacherfl this makes sense to me. I ran everything locally though and I was a bit suprised.... the version of flagd used by default is v0.9.0 (the SidecarTag) not the FlagdTag.

This causes some practical problems since 0.9.0 didn't support the sync or ofrep protocols. I can't immediately see why this seems to be happening.

This has been addressed with #643 :)

bacherfl and others added 2 commits May 23, 2024 08:23
@bacherfl
add glagd image to deployment example
3c9669d 
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@toddbaert
Merge branch 'main' into docs/flagd-resource-docs
26346b3
@toddbaert toddbaert self-requested a review May 23, 2024 11:44
@toddbaert toddbaert merged commit 06b399e into open-feature:main May 23, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat approved these changes

@toddbaert toddbaert toddbaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bacherfl @thisthat @toddbaert