fix: adapt rolebinding to modified manager role #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
beeme1mr
approved these changes
May 29, 2024
|
Rendered chart looks right when tested locally. Merging. |
toddbaert
approved these changes
May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #645
This PR solves the issue by also adapting the ClusterRoleBinding using the recently modified ClusterRole. The reason this was failing is because due to the
deleteoverlay for themanager-role, theopen-feature-operatorprefix was not added to the ClusterRoleBinding anymore, which resulted in the ClusterRoleBinding referring to the wrong ClusterRole (manager-roleinstead ofopen-feature-operator-manager-role)