Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flagd path defaults #658

Merged
merged 4 commits into from
Jun 3, 2024
Merged

fix: flagd path defaults #658

merged 4 commits into from
Jun 3, 2024

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Jun 3, 2024

The previous default paths don't work well, since flagd evaluation requests look like .../flagd.evaluation.v1.Service/.... These new default paths work "out of the box".

image

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested a review from a team as a code owner June 3, 2024 14:24
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deafaults looks good :)

@toddbaert toddbaert merged commit aef1010 into main Jun 3, 2024
15 checks passed
@toddbaert toddbaert deleted the fix/default-flagd-paths branch June 3, 2024 21:32
This was referenced Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants