feat: Improved custom namespace options #678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
7h3-3mp7y-m4n
changed the title
7h3-3mp7y-m4n
changed the title
toddbaert
reviewed
Jun 17, 2024
Comment on lines
+5
to
+9
| namespace: | ||
| name: open-feature-operator-system | ||
| create: true | ||
| labels: {} | ||
| annotations: {} |
There was a problem hiding this comment.
How does this work in conjunction with the old defaultNamespace? What happens if you set defaultNamespace to something different than namespace.name? Should we remove defaultNamespace?
toddbaert
changed the title
|
Please update the readme as well. |
|
I'd like this to resolve #683 as well. @7h3-3mp7y-m4n are you still planning on working on this? No pressure! Just want to know your intent! |
|
okay @toddbaert I'll defenitly like to work on this and let you know on Slack. |
|
I've created a variation of this here to unblock progress on this issue: #702 |
|
Closing this PR in favor of #702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #676