Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enables Kubernetes syncing for flagd #82

Merged
merged 7 commits into from
Sep 14, 2022
Merged

feat: enables Kubernetes syncing for flagd #82

merged 7 commits into from
Sep 14, 2022
+167 −54

Conversation

AlexsJones
Copy link
Member

@AlexsJones AlexsJones commented Aug 31, 2022 •
edited
Loading

  • This now will default to the Kubernetes sync provider
  • It will check and append the current SA to the cluster rolebinding for the flagD notifier API

@AlexsJones AlexsJones changed the title enables kuberentes syncing for flagd feat: enables kuberentes syncing for flagd Aug 31, 2022
@AlexsJones
enables kuberentes syncing for flagd
5652fbc 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones
Update kustomization.yaml
8236668 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones
Update manager.yaml
1a5b64f 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones
using the new flagd v0.1.0 capabilities to leverage k8s provider
5119558 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones AlexsJones marked this pull request as ready for review September 6, 2022 14:58
@AlexsJones AlexsJones changed the title feat: enables kuberentes syncing for flagd feat: enables Kubernetes syncing for flagd Sep 6, 2022
@beeme1mr
Copy link
Member

Hey @AlexsJones, sorry this hasn't been reviewed yet. I've added @james-milligan and @skyerus to see if they can take a look tomorrow.

skyerus
skyerus approved these changes Sep 14, 2022
View reviewed changes
config/samples/end-to-end.yaml Outdated Show resolved Hide resolved
@AlexsJones
reworked to default to the k8s sync provider and inject the right rol…
7067305 
…e bindings

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones
reverted maanger files
0d47866 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
toddbaert
toddbaert approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change.

This now will default to the Kubernetes sync provider

I think this is totally justified now.

Is it worth mentioning this automatic role-binding in the readme?

@AlexsJones
Update flagd_kubernetes_sync_clusterrole.yaml
060636e 
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@AlexsJones
Copy link
Member Author

This is a great change.

This now will default to the Kubernetes sync provider

I think this is totally justified now.

Is it worth mentioning this automatic role-binding in the readme?

I don't think it's necessary, it's part of the machinery. But happy welcome other opinions

@AlexsJones AlexsJones merged commit 933cd94 into main Sep 14, 2022
@AlexsJones AlexsJones deleted the feat/kubernetes-sync branch September 14, 2022 14:23
@beeme1mr beeme1mr mentioned this pull request Sep 14, 2022
Closed
@github-actions github-actions bot mentioned this pull request Sep 27, 2022
Merged
This was referenced Oct 20, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddbaert toddbaert toddbaert approved these changes

@james-milligan james-milligan Awaiting requested review from james-milligan

@skyerus skyerus Awaiting requested review from skyerus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexsJones @beeme1mr @toddbaert @skyerus