feat: added disable-request-logging flag #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Milligan <james@omnant.co.uk>
|
direction change to use the |
james-milligan
added a commit
to open-feature/flagd
that referenced
this pull request
Dec 2, 2022
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> - The `--debug` flag now also controls the logging for requests, when set all logging levels are enabled for the `XXXWithID` `logger` methods and allows the setting of request fields, allowing for improved performance when logs are not required. - `NewLogger` now takes an additional boolean argument to set the internal `reqIDLogging` field, this field is also set to false when the `*zap.Logger` argument is nil ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> ### Notes <!-- any additional notes for this PR --> ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> This flag should be set by default in the operator open-feature/open-feature-operator#260 ### How to test <!-- if applicable, add testing instructions under this section --> Signed-off-by: James Milligan <james@omnant.co.uk> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com> Co-authored-by: Skye Gill <gill.skye95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Milligan james@omnant.co.uk
Leaving as draft until this pr is merged
This PR
disable-request-loggingflag to start command of flagdRelated Issues
Notes
Follow-up Tasks
How to test