Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add all resources individually to tarball #345

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Feb 9, 2023

Helm doesn't automatically perform CRD upgrades. One thing we can do to help this is publish them separately so admins can upgrade these manually apart from helm.

This PR helps the situation by also publishing all our resources individually and including them in the helm tarball, so admins can easily update the CRDs with something like:

helm template open-feature-operator-v0.2.28.tgz -s templates/apiextensions.k8s.io_v1_customresourcedefinition_featureflagconfigurations.core.openfeature.dev.yaml | kubectl apply -f -

Besides this added benefit, there's no change. You can still install the operator with helm install/upgrade as before.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #345 (0d2cc12) into main (56ea082) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files           4        4           
  Lines         532      532           
=======================================
  Hits          327      327           
  Misses        185      185           
  Partials       20       20           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert force-pushed the chore/publish-resources-separately branch from 52ae594 to 51479cf Compare February 9, 2023 05:12
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change to me, thanks!

@beeme1mr
Copy link
Member

@toddbaert can you please address the merge conflicts? Once this is merged, please create a separate PR to update the docs.

@toddbaert
Copy link
Member Author

toddbaert commented Feb 15, 2023

@toddbaert can you please address the merge conflicts? Once this is merged, please create a separate PR to update the docs.

I'd like to wait for a release to update the docs, or it won't be possible/accurate. I'll update the docs then.

@beeme1mr

Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert toddbaert force-pushed the chore/publish-resources-separately branch from 51479cf to 0d2cc12 Compare February 15, 2023 20:51
@toddbaert toddbaert merged commit a0993dc into main Feb 15, 2023
@toddbaert toddbaert deleted the chore/publish-resources-separately branch February 22, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants