-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add all resources individually to tarball #345
Conversation
2f3436d
to
52ae594
Compare
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 61.46% 61.46%
=======================================
Files 4 4
Lines 532 532
=======================================
Hits 327 327
Misses 185 185
Partials 20 20 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
52ae594
to
51479cf
Compare
...sions.k8s.io_v1_customresourcedefinition_featureflagconfigurations.core.openfeature.dev.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good change to me, thanks!
@toddbaert can you please address the merge conflicts? Once this is merged, please create a separate PR to update the docs. |
I'd like to wait for a release to update the docs, or it won't be possible/accurate. I'll update the docs then. |
Signed-off-by: Todd Baert <toddbaert@gmail.com>
51479cf
to
0d2cc12
Compare
Helm doesn't automatically perform CRD upgrades. One thing we can do to help this is publish them separately so admins can upgrade these manually apart from helm.
This PR helps the situation by also publishing all our resources individually and including them in the helm tarball, so admins can easily update the CRDs with something like:
helm template open-feature-operator-v0.2.28.tgz -s templates/apiextensions.k8s.io_v1_customresourcedefinition_featureflagconfigurations.core.openfeature.dev.yaml | kubectl apply -f -
Besides this added benefit, there's no change. You can still install the operator with
helm install/upgrade
as before.