-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reorganize repo for multiple packages #35
chore: reorganize repo for multiple packages #35
Conversation
5963899
to
73730f0
Compare
Signed-off-by: Federico Bond <federicobond@gmail.com>
e3c7bf4
to
5936527
Compare
Tooling is still a bit of a hack, happy to take suggestions. I mostly wanted to get the basic structure right. |
b5aa8a1
to
cf2cad0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 85.12% 90.86% +5.73%
==========================================
Files 6 8 +2
Lines 121 186 +65
==========================================
+ Hits 103 169 +66
+ Misses 18 17 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Federico Bond <federicobond@gmail.com>
cf2cad0
to
3af6ab5
Compare
Signed-off-by: Federico Bond <federicobond@gmail.com>
80f9ce0
to
25d27b9
Compare
Ok, so I did some research on the tooling for packaging and dependency management and after looking at different options, including Flit, Poetry and PDM, I have integrated a tool called Hatch that is being developed under the umbrella of the PyPA. Hatch solves the problem of running tests in isolated environments for each package, which we weren't able to do with the existing Makefile setup. It's easy to understand, fast, and adheres much better to modern Python packaging standards (Poetry is known for doing its own thing, sometimes with questionable choices for package authors). The only downside of Hatch is that there is no explicit monorepo support yet, but I don't believe it to be a deal breaker at the moment. I think we can give it a try and see if works for our use case. Worst case scenario is we have to tweak up pyproject.toml files to use a different tool. |
I'll look into this more tomorrow but it looks like great progress. |
@federicobond could you please sign off on the commits when you have a moment? |
Signed-off-by: Federico Bond <federicobond@gmail.com>
a77970e
to
6f7a067
Compare
Sure! I was missing the last one apparently, sorry about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 🍻
Co-authored-by: Anton Grübel <anton.gruebel@gmail.com> Signed-off-by: Federico Bond <federicobond@gmail.com>
This is a
work-in-progressproposal for organizing the repo around multiple packages