-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include proto file in build for openfeature-provider-flagd #45
Conversation
Signed-off-by: Federico Bond <federicobond@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
===========================================
- Coverage 90.55% 71.04% -19.52%
===========================================
Files 8 10 +2
Lines 180 297 +117
===========================================
+ Hits 163 211 +48
- Misses 17 86 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@toddbaert damn, hatch requires python 3.9+. I have to go now, but feel free to edit this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a similar solution, but yours seems better 😄
the plugin requires Python 3.9 😢 |
No worries! Bummer about 3.8... Looks like it isn't eol until October... Not sure we should drop early, but that's an option. |
d0206b4
to
d09e9b5
Compare
Signed-off-by: Federico Bond <federicobond@gmail.com>
d09e9b5
to
8e8ff2e
Compare
This should fix #44. hatch now generates the proto client files during the build stage.
We can probably find a cleaner solution later.