fix: fix types for HookContext.{client,provider}_metadata #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobond
force-pushed
the
fix-types-2
branch
from
dc1f8ef
to
a53e868
Compare
Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
fix-types-2
branch
from
a53e868
to
63b7808
Compare
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
==========================================
- Coverage 93.84% 93.45% -0.40%
==========================================
Files 16 16
Lines 439 443 +4
==========================================
+ Hits 412 414 +2
- Misses 27 29 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
beeme1mr
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Corrects type information for some HookContext fields. Yup, it's ugly to prevent a circular import problem, there might be a better way to do it but I haven't found it.