Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make specific fields in HookContext immutable #266

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Jan 28, 2024

This PR

  • also added tests to cover section 4.1

Related Issues

Relates #2

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1b0839) 93.89% compared to head (3af1096) 93.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   93.89%   93.94%   +0.05%     
==========================================
  Files          16       16              
  Lines         442      446       +4     
==========================================
+ Hits          415      419       +4     
  Misses         27       27              
Flag Coverage Δ
unittests 93.94% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@federicobond federicobond merged commit 3b89760 into open-feature:main Jan 29, 2024
12 checks passed
@gruebel gruebel deleted the add-hook-context-tests branch January 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants