Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert image labels from symlink destination to symlink source #45

Open
youngdjn opened this issue Dec 12, 2023 · 1 comment · May be fixed by #61
Open

Convert image labels from symlink destination to symlink source #45

youngdjn opened this issue Dec 12, 2023 · 1 comment · May be fixed by #61
Assignees

Comments

@youngdjn
Copy link
Collaborator

youngdjn commented Dec 12, 2023

As a part of #46 , we need to undo the Metashape operation that replaces the symlink location (source) with its destination. We want the image labels to indicate the symlink source, especially for compatibility with tools like DVC and Datalad that store the actual file (destination) in a flattened and hashed annex that is not human-readable or human-writeable.

This utility should be idempotent so that if it is run on a dataset where this was already corrected (or that never had this issue to begin with), it does not make any changes.

It should runnable from a script (either as a command line call or function call) in a way that allows running it from the metashape_workflow.py script.

@youngdjn youngdjn transferred this issue from open-forest-observatory/automate-metashape_archive Jun 3, 2024
@russelldj
Copy link
Contributor

russelldj commented Jun 10, 2024

This PR adds the logic for undoing the symlinks. In that case, the intent was to run the script only in situations where this was a known issue. So additional logic will be required to make it idempotent.

@russelldj russelldj linked a pull request Jul 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants