Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate admin JSON components to Monaco editor #4424

Closed
5 tasks done
Viicos opened this issue Jun 20, 2024 · 1 comment · Fixed by #4407
Closed
5 tasks done

Migrate admin JSON components to Monaco editor #4424

Viicos opened this issue Jun 20, 2024 · 1 comment · Fixed by #4407
Assignees
@sergei-maertens
Labels
enhancement
Milestone
Release 2.8.0

Comments

@Viicos
Copy link
Contributor

Viicos commented Jun 20, 2024 •
edited by sergei-maertens
Loading

Thema / Theme

Admin

Omschrijving / Description

Following #4051, there are still places where the Monaco Editor can be used in the admin, but requires more work regarding styling.

In order of priority:

  • Form logic rules: Advanced JSON-logic trigger
  • Form logic rules: Assign variable-action
  • Variables tab: Default value for objects and arrays
  • Service fetch logic expression
  • Form logic rules: Show DSL

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response
@Viicos Viicos added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Jun 20, 2024
@Viicos Viicos mentioned this issue Jun 20, 2024
Merged
9 tasks
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Jun 24, 2024
@joeribekker
Copy link
Contributor

joeribekker commented Jun 24, 2024 •
edited
Loading

Estimate: 1 week; no reason to touch the existing editors but the new editor is easier to maintain.

@joeribekker joeribekker added this to the Release 2.8.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
enhancement
Projects
Development
Archived in project
Milestone
Release 2.8.0
Development

Successfully merging a pull request may close this issue.

[#4051] Use new JSON editor open-formulieren/open-forms
3 participants
@joeribekker @sergei-maertens @Viicos