Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planet Tutorial Wording and Clarification Improvements for Step 4 (fixes #2519) #2521

Conversation

johnmdrake1
Copy link
Contributor

Fixes #2519

Checklist

[x] Check for issue number in pull request title
[x] Are there any unneeded files in the pull request?
[x] Did they make a branch for their patch?
[x] Does the pull request actually fix the issue?
[x] Check the pull request on raw.githack, does it display without any errors?
[x] Is there any merge conflicts?
[x] Make sure that people use their GitHub accounts when making commits through git

Raw.Githack preview link

https://raw.githack.com/johnmdrake1/johnmdrake1.github.io/step4-planet-wordingfix-johnmdrake1/#!pages/vi/vi-planetapps.md

pages/vi/vi-planetapps.md Outdated Show resolved Hide resolved
@@ -84,12 +84,12 @@ Take the course, and the last question will ask you to specify any problems or i
![Submissions button](images/vi-planet-submissions-button.png)
![View Submissions](images/vi-planet-submissions.png)

6. When you provide feedback, try to be as specific as possible, and include screenshots when necessary
6. When you provide feedback, try to be as specific as possible, and include screenshots when necessary, through your preferred method (Gitter chat is always a great fallback if you are not comfortable with uploading and linking screenshots).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnmdrake1 can you explain this statement? Are you trying to say you should upload screenshot or saying not to use gitter if you are not familiar with that feature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was taking the planet course, there was nowhere I saw in the free response feedback question to upload a photo or screenshot, I checked the toolbar at the top of the text entry field for an attachment button and didn't see one unless I missed it. I personally uploaded my screenshots to Imgur, and made a private Imgur link to my album which I put in my answer to question 12. Not everyone may know how to use screenshot sharing websites such as Imgur, so I was saying use Gitter if you don't know another way. If there is a preferred image hosting site OLE would like Virtual Interns to use for that question that should go there instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Immrssa

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leomaxi comes up, if that's your tag my apologies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lillyxxx completely agreed. Thoughts @lmmrssa So I can get this issue and pull request sorted out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnmdrake1 @lillyxxx as mentioned planet does not have way to upload image on exam. If question is confusing we can change the question which is not part of this repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, in my opinion that is what should be done. On my end, should I take out my addition about how to upload images on the exam, and the Planet team can change the question in the appropriate repository? @lmmrssa

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmmrssa is this better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see most recent commit)

@lmmrssa lmmrssa closed this Jul 16, 2019
Kuljeet1998 pushed a commit to Kuljeet1998/Kuljeet1998.github.io that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planet Tutorial (Step 4) Improvements and Clarifications
6 participants