Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #16742 - allow all the tier tags to be assign on entity #16823

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Fix: #16742 - allow all the tier tags to be assign on entity #16823

merged 6 commits into from
Jun 28, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes #16742

Screen.Recording.2024-06-27.at.6.32.45.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Governance e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs and removed UI UI specific issues labels Jun 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.2% (35287/54122) 41.99% (13968/33266) 43.98% (4332/9849)

@cypress Cypress
Copy link

cypress bot commented Jun 27, 2024 •
edited
Loading

Passing run #34545 ↗︎

0 124 262 0 Flakiness 0

Details:

update variable
Project: openmetadata Commit: 0782268821
Status: Passed Duration: 16:52 💡
Started: Jun 27, 2024 4:38 PM Ended: Jun 27, 2024 4:55 PM

Review all test suite changes for PR #16823 ↗︎

ShaileshParmar11
ShaileshParmar11 reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

openmetadata-ui/src/main/resources/ui/playwright/support/tag/TagClass.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/support/tag/TagClass.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/support/tag/TagClass.ts Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/utils/tag.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
24.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit a034a97 into main Jun 28, 2024
17 checks passed
@chirag-madlani chirag-madlani deleted the fix-#16742 branch June 28, 2024 05:40
harshach pushed a commit that referenced this pull request Jun 30, 2024
@chirag-madlani @harshach
Fix: #16742 - allow all the tier tags to be assign on entity (#16823)
f374fa2 
* fix(ui): consider all the tags as tier which are children of Tier classification

* add playwright

* wip tier cleanup

* fix async select list loading issue

* address comments

* update variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
e2e:DataAssets e2e:Governance safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new Tier Option is updating the tag but NOT the tier
2 participants
@chirag-madlani @ShaileshParmar11