-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Update VAN #1017
[Enhancement] Update VAN #1017
Conversation
Codecov ReportBase: 86.14% // Head: 86.14% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## dev #1017 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 140 140
Lines 9676 9676
Branches 1677 1677
=======================================
Hits 8335 8335
Misses 1090 1090
Partials 251 251
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to keep "tiny", "small", "large" structs before adding 'b0', 'b1' etc. This will be compatible with previous versions. You can add a new config name 'b0' but use the same checkpoint with 'tiny'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Ezra-Yu |
@okotaku Welcome to migrating it to dev-1.x if it's convenient for you. Yes, we plan to migrate the last few PRs on Although we need to sync |
Motivation
1. Use new Architecture named series
previous arch names : 'tiny', 'small', 'base' and 'large'
previous arch names : 'b0', 'b1', 'b2' and 'b3' .....
And the 'b0' is totally equal to 'tiny'; the 'b1' is totally equal to 'small'; the 'b2' is totally equal to 'base'; the 'b3' is totally equal to 'large'.
2. Add new release weight form Official repo
Checklist
Before PR:
After PR: