Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Update VAN #1017

Merged
merged 9 commits into from
Sep 27, 2022
Merged

[Enhancement] Update VAN #1017

merged 9 commits into from
Sep 27, 2022

Conversation

okotaku
Copy link
Collaborator

@okotaku okotaku commented Sep 7, 2022

Motivation

1. Use new Architecture named series

previous arch names : 'tiny', 'small', 'base' and 'large'
previous arch names : 'b0', 'b1', 'b2' and 'b3' .....

And the 'b0' is totally equal to 'tiny'; the 'b1' is totally equal to 'small'; the 'b2' is totally equal to 'base'; the 'b3' is totally equal to 'large'.

2. Add new release weight form Official repo

  • add 'b4' weight with ACC of 84.13@224
  • add 'b4' ,'b5', 'b6' pre-trained weights in ImageNet-21k dataset

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Base: 86.14% // Head: 86.14% // No change to project coverage 👍

Coverage data is based on head (9b17acc) compared to base (ec71d07).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1017   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files         140      140           
  Lines        9676     9676           
  Branches     1677     1677           
=======================================
  Hits         8335     8335           
  Misses       1090     1090           
  Partials      251      251           
Flag Coverage Δ
unittests 86.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/van.py 96.83% <ø> (ø)
mmcls/models/utils/attention.py 96.91% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to keep "tiny", "small", "large" structs before adding 'b0', 'b1' etc. This will be compatible with previous versions. You can add a new config name 'b0' but use the same checkpoint with 'tiny'.

@okotaku okotaku requested a review from Ezra-Yu September 8, 2022 09:42
@Ezra-Yu Ezra-Yu changed the title [Feature] Update VAN [Enhancement] Update VAN Sep 9, 2022
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 56589ee into open-mmlab:dev Sep 27, 2022
@okotaku
Copy link
Collaborator Author

okotaku commented Sep 29, 2022

@Ezra-Yu
Should I make this PR again for dev-1.x?
Or do you plan to incorporate PRs that have been merged into dev by the mmlab team into dev-1.x as well?

@Ezra-Yu
Copy link
Collaborator

Ezra-Yu commented Sep 29, 2022

@okotaku Welcome to migrating it to dev-1.x if it's convenient for you.

Yes, we plan to migrate the last few PRs on dev to dev_1.x in the remaining months of this year.

Although we need to sync master with 1.x updates in principle. But if time is not enough, supporting new features to 1.x has a higher priority. So next time, if you want to add a new feature, please add it directly to the 1.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants