-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Fixed typo in pytorch2torchscript.md #1173
[Docs] Fixed typo in pytorch2torchscript.md #1173
Conversation
please fix the lint, refer to this doc. If you have any questions, please feel free to contact us. |
Thank you for your comment. Why there is a warning in the file which I haven't changed? |
Sorry that, it seems to be a legacy, And could you fix it in this PR, refer to https://mmclassification.readthedocs.io/en/latest/community/CONTRIBUTING.html#code-style in $MMCls
pip install -U pre-commit
pre-commit install 2 run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov ReportBase: 86.02% // Head: 86.02% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1173 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 142 142
Lines 9906 9906
Branches 1715 1715
=======================================
Hits 8522 8522
Misses 1122 1122
Partials 262 262
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fixed typo in pytorch2torchscript.md
Modification
Before:
python tools/deployment/pytorch2onnx.py
After:
python tools/deployment/pytorch2torchscript.py
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: