Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Use zero as default value of thrs in metrics. #341

Merged
merged 4 commits into from
Jul 18, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Jul 5, 2021

Use zero as the default value of thrs in metrics. And it accepts a number instead of a float now.

@mzr1996 mzr1996 changed the title Use zero as default value of thrs in metrics. [Fix] Use zero as default value of thrs in metrics. Jul 5, 2021
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #341 (f7224f9) into master (24e58ba) will increase coverage by 0.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   76.00%   76.02%   +0.01%     
==========================================
  Files          96       96              
  Lines        5113     5113              
  Branches      850      849       -1     
==========================================
+ Hits         3886     3887       +1     
  Misses       1108     1108              
+ Partials      119      118       -1     
Flag Coverage Δ
unittests 76.02% <94.44%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/losses/accuracy.py 88.23% <83.33%> (+0.91%) ⬆️
mmcls/core/evaluation/eval_metrics.py 80.76% <100.00%> (-0.25%) ⬇️
mmcls/datasets/base_dataset.py 90.80% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e58ba...f7224f9. Read the comment docs.

Copy link
Contributor

@ycxioooong ycxioooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycxioooong
Copy link
Contributor

@mzr1996 please resolve the conflicts before merging.

@mzr1996
Copy link
Member Author

mzr1996 commented Jul 14, 2021

@mzr1996 please resolve the conflicts before merging.

Done

@ycxioooong ycxioooong merged commit 15cd34b into open-mmlab:master Jul 18, 2021
@mzr1996 mzr1996 deleted the metrics-thrs-default branch July 28, 2021 03:34
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Use zero as default value of `thrs` in metrics. And it accepcts a number
instead of float now.

* Fix unit test comment

* Don't pass thrs if no thrs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants