-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Use zero as default value of thrs
in metrics.
#341
Conversation
thrs
in metrics.thrs
in metrics.
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 76.00% 76.02% +0.01%
==========================================
Files 96 96
Lines 5113 5113
Branches 850 849 -1
==========================================
+ Hits 3886 3887 +1
Misses 1108 1108
+ Partials 119 118 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mzr1996 please resolve the conflicts before merging. |
…metrics-thrs-default
Done |
* Use zero as default value of `thrs` in metrics. And it accepcts a number instead of float now. * Fix unit test comment * Don't pass thrs if no thrs.
Use zero as the default value of
thrs
in metrics. And it accepts a number instead of a float now.