Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Use local ATTENTION registry to avoid conflict with other repo. #375

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Jul 26, 2021

Refers to #369.

@mzr1996 mzr1996 requested a review from Ezra-Yu July 26, 2021 10:20
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #375 (b99199f) into master (899047a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   76.01%   76.02%           
=======================================
  Files          96       96           
  Lines        5112     5114    +2     
  Branches      849      849           
=======================================
+ Hits         3886     3888    +2     
  Misses       1108     1108           
  Partials      118      118           
Flag Coverage Δ
unittests 76.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/builder.py 95.00% <100.00%> (+0.55%) ⬆️
mmcls/models/utils/attention.py 96.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 899047a...b99199f. Read the comment docs.

@mzr1996 mzr1996 changed the title [Fix] Use local ATTENTION registery to avoid conflict with other repo. [Fix] Use local ATTENTION registry to avoid conflict with other repo. Jul 26, 2021
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Good.

Copy link
Member Author

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@mzr1996 mzr1996 deleted the fix-attn-registery branch July 28, 2021 03:34
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants