-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Update digit_version
function.
#402
Conversation
parse_version_info
function.digit_version
and parse_version_info
function.
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 76.51% 76.63% +0.12%
==========================================
Files 97 97
Lines 5224 5234 +10
Branches 856 857 +1
==========================================
+ Hits 3997 4011 +14
+ Misses 1108 1103 -5
- Partials 119 120 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
digit_version
and parse_version_info
function.digit_version
and parse_version_info
function.
This reverts commit da93cac.
digit_version
and parse_version_info
function.digit_version
function.
digit_version
function.digit_version
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update digit_version * Add digit_version unit test
Motivation
The previous
digit_version
function has some problems, refers to open-mmlab/mmcv#1185Modification
Copy the
digit_version
from mmcv and use it to parse versions.BC-breaking (Optional)
No
Checklist
Before PR:
After PR: