Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Update digit_version function. #402

Merged
merged 5 commits into from
Aug 12, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Aug 11, 2021

Motivation

The previous digit_version function has some problems, refers to open-mmlab/mmcv#1185

Modification

Copy the digit_version from mmcv and use it to parse versions.

BC-breaking (Optional)

No

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 changed the title [Enhance] Update parse_version_info function. [Enhance] Update digit_version and parse_version_info function. Aug 11, 2021
@mzr1996
Copy link
Member Author

mzr1996 commented Aug 11, 2021

@zhouzaida

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #402 (b951397) into master (a747458) will increase coverage by 0.12%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   76.51%   76.63%   +0.12%     
==========================================
  Files          97       97              
  Lines        5224     5234      +10     
  Branches      856      857       +1     
==========================================
+ Hits         3997     4011      +14     
+ Misses       1108     1103       -5     
- Partials      119      120       +1     
Flag Coverage Δ
unittests 76.63% <86.95%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/__init__.py 89.65% <86.95%> (+19.06%) ⬆️
mmcls/datasets/imagenet.py 25.53% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a747458...b951397. Read the comment docs.

@mzr1996 mzr1996 changed the title [Enhance] Update digit_version and parse_version_info function. [WIP] Update digit_version and parse_version_info function. Aug 11, 2021
@mzr1996 mzr1996 changed the title [WIP] Update digit_version and parse_version_info function. [WIP] Update digit_version function. Aug 12, 2021
@mzr1996 mzr1996 requested a review from Ezra-Yu August 12, 2021 02:35
@mzr1996 mzr1996 changed the title [WIP] Update digit_version function. [Enhance] Update digit_version function. Aug 12, 2021
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit c0a4916 into open-mmlab:master Aug 12, 2021
@mzr1996 mzr1996 deleted the version-parse branch August 13, 2021 09:51
@RangiLyu RangiLyu mentioned this pull request Sep 23, 2021
6 tasks
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Update digit_version

* Add digit_version unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants