Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Fix TnT compatibility and verbose warning. #436

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Sep 8, 2021

Motivation

TnT does not support return tuple now. And the warning in extract_feat will show in every call.

Modification

As the title

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu September 8, 2021 08:53
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #436 (9ba3c96) into master (a8f4f82) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         100      100           
  Lines        5356     5356           
  Branches      883      883           
=======================================
  Hits         4139     4139           
  Misses       1098     1098           
  Partials      119      119           
Flag Coverage Δ
unittests 77.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/tnt.py 99.08% <100.00%> (ø)
mmcls/models/classifiers/image.py 86.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f4f82...9ba3c96. Read the comment docs.

Copy link
Contributor

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a period after default value in docstring.

@mzr1996
Copy link
Member Author

mzr1996 commented Sep 22, 2021

Should add a period after default value in docstring.

Good, but maybe in another pull request.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 75b087f into open-mmlab:master Sep 22, 2021
@mzr1996 mzr1996 deleted the compat-downstream branch July 20, 2022 07:08
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Support return tuple in TnT

* Fix verbose warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants