Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update mmcv,torch,cuda version in Dockerfile and doc #594

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Dec 8, 2021

Motivation

Update mmcv,torch,cuda version in Dockerfile and doc

Modification

docker/Dockerfile
install.md

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Ezra-Yu Ezra-Yu requested a review from mzr1996 December 8, 2021 09:26
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #594 (9cd6900) into master (58ab028) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   80.01%   80.01%           
=======================================
  Files         109      109           
  Lines        6419     6419           
  Branches     1102     1102           
=======================================
  Hits         5136     5136           
  Misses       1146     1146           
  Partials      137      137           
Flag Coverage Δ
unittests 80.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ab028...9cd6900. Read the comment docs.

Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit 72b0da8 into open-mmlab:master Dec 8, 2021
@Ezra-Yu Ezra-Yu deleted the fix-dockerfile branch July 18, 2022 08:47
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants