Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Enhance vis-pipeline tool #604

Merged
merged 16 commits into from
Mar 4, 2022

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Dec 15, 2021

Motivation

Enhance vis-pipeline tool refer to #561

Modification

  1. add 'transformed' mode to vis transformed images.
  2. modify 'pipeline' mode to vis intermediate images.
  3. replace example pictures with url link, remove real pictures docs/_static/xxxx

BC-breaking (Optional)

the behave of mode 'pipeline' has changed.

Use cases (Optional)

  1. 'transformed' mode
 python ./tools/visualizations/vis_pipeline.py ./configs/resnet/resnet50_8xb32_in1k.py --show --mode transformed
  1. pipeline' mode
python ./tools/visualizations/vis_pipeline.py configs/swin_transformer/swin_base_224_b16x64_300e_imagenet.py --phase train --adaptive --mode pipeline --show

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #604 (7aeea42) into dev (9ee4157) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #604      +/-   ##
==========================================
- Coverage   85.03%   84.88%   -0.16%     
==========================================
  Files         121      121              
  Lines        7393     7476      +83     
  Branches     1278     1288      +10     
==========================================
+ Hits         6287     6346      +59     
- Misses        916      942      +26     
+ Partials      190      188       -2     
Flag Coverage Δ
unittests 84.80% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/dataset_wrappers.py 70.58% <0.00%> (-21.08%) ⬇️
mmcls/models/losses/utils.py 56.25% <0.00%> (-1.33%) ⬇️
mmcls/datasets/utils.py 38.29% <0.00%> (ø)
mmcls/models/utils/attention.py 100.00% <0.00%> (ø)
mmcls/models/backbones/resnet.py 100.00% <0.00%> (ø)
mmcls/models/heads/stacked_head.py 100.00% <0.00%> (ø)
mmcls/models/backbones/regnet.py 98.05% <0.00%> (+0.01%) ⬆️
mmcls/models/backbones/shufflenet_v1.py 97.93% <0.00%> (+0.02%) ⬆️
mmcls/models/backbones/conformer.py 98.21% <0.00%> (+0.03%) ⬆️
mmcls/datasets/pipelines/transforms.py 88.27% <0.00%> (+0.04%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee4157...7aeea42. Read the comment docs.

@Ezra-Yu Ezra-Yu requested a review from mzr1996 January 13, 2022 06:08
tools/visualizations/vis_pipeline.py Outdated Show resolved Hide resolved
@Ezra-Yu Ezra-Yu changed the base branch from master to dev February 24, 2022 11:00
@Ezra-Yu Ezra-Yu requested a review from yingfhu February 24, 2022 12:36
Copy link
Collaborator

@yingfhu yingfhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit d08c2a1 into open-mmlab:dev Mar 4, 2022
@Ezra-Yu Ezra-Yu deleted the enhance-vis-pipeline branch July 18, 2022 08:47
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* enhance vis-pipeline add intermediate imgs

* enhance vis-pipeline add intermediate imgs

* improve code of vi-pipeline

* modify docs for vis-pipeline

* Use `mmcv.utils.digit_version` instead of `distutils`

* add size info in the bottom

* preform adaptive-resize in before concat

* add warning info

* fix docs

* fix lint

* fix comment

* fix docs

Co-authored-by: mzr1996 <mzr1996@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants