Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix potential unexcepted behaviors if metric_options is not specified in multi-label evaluation. #647

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

dreamer121121
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

muti-label test bug, default metric-options is {}.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2022

CLA assistant check
All committers have signed the CLA.

@mzr1996 mzr1996 changed the base branch from master to dev January 13, 2022 11:23
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996
Copy link
Member

mzr1996 commented Jan 13, 2022

@dreamer121121 Thanks for your contribution. Please sign the CLA and then we can merge your code.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #647 (7cbc987) into dev (a451d63) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 7cbc987 differs from pull request most recent head f55ab6f. Consider uploading reports for the commit f55ab6f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #647   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         120      120           
  Lines        7045     7045           
  Branches     1228     1228           
=======================================
  Hits         5796     5796           
  Misses       1075     1075           
  Partials      174      174           
Flag Coverage Δ
unittests 82.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/multi_label.py 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a451d63...f55ab6f. Read the comment docs.

mmcls/datasets/multi_label.py Outdated Show resolved Hide resolved
@mzr1996 mzr1996 changed the title Update multi_label.py [Fix] Fix potential unexcepted behaviors if metric_options is not specified in multi-label evaluation. Jan 27, 2022
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit 8488a78 into open-mmlab:dev Jan 27, 2022
Ezra-Yu pushed a commit to Ezra-Yu/mmclassification that referenced this pull request Feb 14, 2022
…pecified in multi-label evaluation. (open-mmlab#647)

* Update multi_label.py

* Fix lint

Co-authored-by: mzr1996 <mzr1996@163.com>
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
…pecified in multi-label evaluation. (open-mmlab#647)

* Update multi_label.py

* Fix lint

Co-authored-by: mzr1996 <mzr1996@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants