-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix bug which breaks cal_train_time
in analyze_logs.py
.
#662
Conversation
Please sign the CLA so we can review this PR. |
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 118 118
Lines 6820 6820
Branches 1174 1174
=======================================
Hits 5578 5578
Misses 1082 1082
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cal_train_time
in analyze_logs.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…en-mmlab#662) * fix bug mmclassification issues 661 open-mmlab#661 * fix lint Co-authored-by: Zhicheng Chen <chen1319276472@foxmail.com>
Hi @xiefeifeihu !First of all, we want to express our gratitude for your significant PR in the mmpretrain project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
#661
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: