Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update README in configs according to OpenMMLab standard. #672

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Jan 25, 2022

Modification

As the title

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu January 25, 2022 09:47
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #672 (70f858e) into dev (a451d63) will not change coverage.
The diff coverage is n/a.

❗ Current head 70f858e differs from pull request most recent head 935d63d. Consider uploading reports for the commit 935d63d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #672   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         120      120           
  Lines        7045     7045           
  Branches     1228     1228           
=======================================
  Hits         5796     5796           
  Misses       1075     1075           
  Partials      174      174           
Flag Coverage Δ
unittests 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a451d63...935d63d. Read the comment docs.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 833152b into open-mmlab:dev Jan 26, 2022
Ezra-Yu pushed a commit to Ezra-Yu/mmclassification that referenced this pull request Feb 14, 2022
…n-mmlab#672)

* Update README according to OpenMMLab standard.

* Update model zoo docs generation.

* Revert modification for paperlink
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
…n-mmlab#672)

* Update README according to OpenMMLab standard.

* Update model zoo docs generation.

* Revert modification for paperlink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants