Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reproduction] Reproduce training results of DeiT. #711

Merged
merged 6 commits into from
Mar 2, 2022
Merged

[Reproduction] Reproduce training results of DeiT. #711

merged 6 commits into from
Mar 2, 2022

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Feb 23, 2022

Motivation

The training results of DeiT have been reproduced.

Modification

  1. Update DeiT training configs.
  2. Format and update all readme.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu February 23, 2022 04:28
Ezra-Yu
Ezra-Yu reviewed Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to add some comments in the deit-tiny configs that there are no ema, mixup, cutmix.

configs/deit/README.md Show resolved Hide resolved
@mzr1996 mzr1996 requested a review from Ezra-Yu February 28, 2022 08:04
Ezra-Yu
Ezra-Yu approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 9fd35dd into open-mmlab:dev Mar 2, 2022
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
@mzr1996
[Reproduction] Reproduce training results of DeiT. (open-mmlab#711)
1232944 
* Update deit training settings

* Update decay config

* Add mixup&cutmix and drop path rate

* Update training configs

* Update model-zoo

* Add comments
@mzr1996 mzr1996 deleted the deit-train branch December 7, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ezra-Yu Ezra-Yu Ezra-Yu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzr1996 @Ezra-Yu