-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support Stanford Cars dataset. #893
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #893 +/- ##
==========================================
+ Coverage 85.86% 85.90% +0.03%
==========================================
Files 137 138 +1
Lines 9363 9398 +35
Branches 1621 1627 +6
==========================================
+ Hits 8040 8073 +33
- Misses 1082 1084 +2
Partials 241 241
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
70b8905
to
7b1af11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
requirements/runtime.txt
Outdated
@@ -1,3 +1,4 @@ | |||
matplotlib | |||
numpy | |||
packaging | |||
scipy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the scipy
to the optional requirement file.
mmcls/datasets/stanford_car.py
Outdated
data = sio.loadmat(self.test_ann_file) | ||
else: | ||
data = sio.loadmat(self.train_ann_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please import scipy.io
only when using it. The scipy
package is a little large, and if we only use it in a dataset class, don't make it a required package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in the unit tests.
* feat: add stanford car dataset * feat: add stanford car dataset * feat: add stanford car dataset * feat: add stanford car dataset * feat: add stanford car dataset * feat: add stanford car dataset * Update links and using cars insteam of car * place ependency scipy from runtime to optional * Fix docstring Co-authored-by: Ezra-Yu <1105212286@qq.com> Co-authored-by: mzr1996 <mzr1996@163.com>
Hi @zzc98 !First of all, we want to express our gratitude for your significant PR in the MMClassification project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
Motivation
Support Stanford Car dataset .
Example
Checklist
Before PR:
After PR: