Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade onnxsim to v0.4.0 #915

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Upgrade onnxsim to v0.4.0 #915

merged 1 commit into from
Sep 13, 2022

Conversation

daquexian
Copy link

Motivation

I'm the author of onnx-simplifier. Recently I published onnxsim v0.4.0. In the latest version, dynamic input shapes are natively supported with no need for extra flags like dynamic_input_shapes. custom_lib and input_data is also not needed.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2022

CLA assistant check
All committers have signed the CLA.

@@ -113,26 +113,12 @@ def pytorch2onnx(model,
import onnxsim
from mmcv import digit_version

min_required_version = '0.3.0'
assert digit_version(mmcv.__version__) >= digit_version(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like a typo

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #915 (3f71c11) into master (d2e5054) will decrease coverage by 0.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
- Coverage   85.46%   84.82%   -0.65%     
==========================================
  Files         132      132              
  Lines        8750     8749       -1     
  Branches     1513     1513              
==========================================
- Hits         7478     7421      -57     
- Misses       1050     1090      +40     
- Partials      222      238      +16     
Flag Coverage Δ
unittests 84.82% <ø> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/utils/setup_env.py 72.72% <0.00%> (-27.28%) ⬇️
mmcls/models/utils/helpers.py 79.16% <0.00%> (-20.84%) ⬇️
mmcls/models/backbones/convnext.py 80.00% <0.00%> (-14.79%) ⬇️
mmcls/datasets/custom.py 88.52% <0.00%> (-11.48%) ⬇️
mmcls/models/backbones/convmixer.py 88.52% <0.00%> (-9.84%) ⬇️
mmcls/datasets/builder.py 78.37% <0.00%> (-9.46%) ⬇️
mmcls/models/backbones/cspnet.py 88.23% <0.00%> (-4.58%) ⬇️
mmcls/core/visualization/image.py 86.20% <0.00%> (-0.98%) ⬇️
mmcls/datasets/dataset_wrappers.py 71.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e5054...3f71c11. Read the comment docs.

@mzr1996
Copy link
Member

mzr1996 commented Aug 2, 2022

Thanks for your contribution. In fact, the deploy functionalities in mmclassification are deprecating, we move all these functionalities to mmdeploy. Have you informed them?

@mzr1996 mzr1996 changed the base branch from master to dev September 13, 2022 07:13
@mzr1996 mzr1996 merged commit 6d8c918 into open-mmlab:dev Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants