Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration Plan v1.3.7 - June 2021 #1098

Closed
8 tasks
ZwwWayne opened this issue Jun 14, 2021 · 3 comments
Closed
8 tasks

Iteration Plan v1.3.7 - June 2021 #1098

ZwwWayne opened this issue Jun 14, 2021 · 3 comments

Comments

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Jun 14, 2021

MMCV v1.3.6 has been released, see the plan and the release notes
We list our plan for v1.3.7, which will be released on June 26th.
The PRs from the communities will also be listed here.
Thus, developers could comprehensively know the plan and the progress.

Features:

Enhancements:

If you have created a PR and wish it to be merged in this version, feel free to leave a message in this issue. We will update our plan accordingly here.

@ZwwWayne ZwwWayne pinned this issue Jun 14, 2021
@yeliudev
Copy link
Contributor

yeliudev commented Jun 18, 2021

Hi @ZwwWayne! May I ask that will the ConvModule inherit from BaseModule in the newer version of mmcv? Currently, the ConvModule may not be properly initialized using init_cfg.

class Net(BaseModule):

    def __init__(self, init_cfg=dict(type='Constant', layer='Conv2d', val=0)):
        super(Net, self).__init__(init_cfg)
        self.conv_module = ConvModule(128, 128, 3)

In this case, self.conv_module will be finally initialized by its own method (kaiming normal) but not constant since ConvModule can not determine whether itself has been initialized using self._is_init.

@zhouzaida zhouzaida unpinned this issue Jun 21, 2021
@zhouzaida
Copy link
Collaborator

Hi @ZwwWayne! May I ask that will the ConvModule inherit from BaseModule in the newer version of mmcv? Currently, the ConvModule may not be properly initialized using init_cfg.

class Net(BaseModule):

    def __init__(self, init_cfg=dict(type='Constant', layer='Conv2d', val=0)):
        super(Net, self).__init__(init_cfg)
        self.conv_module = ConvModule(128, 128, 3)

In this case, self.conv_module will be finally initialized by its own method (kaiming normal) but not constant since ConvModule can not determine whether itself has been initialized using self._is_init.

@MeowZheng

@MeowZheng
Copy link
Collaborator

Many thanks for you reporting this issue. It is a little difficult, as the inner parts have higher priority, but we will solve it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants