Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Remove 50000 points sampling from SUN RGB-D preprocessing #1555

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

filaPro
Copy link
Contributor

@filaPro filaPro commented Jun 14, 2022

Motivation

Voxel-based methods use more then 50000 points and are able to use unlimited amount of points. So we skip point sampling during preprocessing and keep the possibility for users to sample any amount with PointSample further.

Modification

Add num_points to SUN RGB-D preprocessing script.

BC-breaking (Optional)

Users may update there *.pkl files, however the metrics of all models will be the same. The minimal changes may be due to randomness in sampling.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1555 (f975a16) into dev (9739046) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1555      +/-   ##
==========================================
+ Coverage   50.15%   50.16%   +0.01%     
==========================================
  Files         223      223              
  Lines       19113    19104       -9     
  Branches     3136     3134       -2     
==========================================
- Hits         9586     9584       -2     
+ Misses       8948     8941       -7     
  Partials      579      579              
Flag Coverage Δ
unittests 50.16% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/bbox/structures/depth_box3d.py 88.67% <0.00%> (+5.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9739046...f975a16. Read the comment docs.

Tai-Wang
Tai-Wang previously approved these changes Jun 15, 2022
@Tai-Wang Tai-Wang dismissed their stale review June 15, 2022 07:19

May need to add some notes in the compatibility doc

@ZwwWayne ZwwWayne merged commit 348db56 into open-mmlab:dev Jun 22, 2022
@filaPro filaPro deleted the sunrgbd_sampling branch June 22, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants