-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Support export logs of different ranks in debug mode #968
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
=======================================
Coverage ? 76.59%
=======================================
Files ? 139
Lines ? 11033
Branches ? 2206
=======================================
Hits ? 8451
Misses ? 2216
Partials ? 366
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest adding hostname and local rank to the filename for multi-node debug.
For example:
import socket
hostname = socket.gethostname()
global_rank = get_rank()
local_rank = int(os.environ['LOCAL_RANK'])
self._log_dir = osp.join(
self.work_dir, self.timestamp + '_rank' + str(global_rank) +
'_localrank' + str(local_rank) + '_' + hostname)
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
If the
log_level
is "DEBUG", logger will export logs of different ranks like this:1 node 8 GPUs:
2 node 2 GPUs per node
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist