-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Support writing data to vis_backend
with prefix
#972
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
=======================================
Coverage ? 76.63%
=======================================
Files ? 139
Lines ? 10993
Branches ? 2202
=======================================
Hits ? 8425
Misses ? 2203
Partials ? 365
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
vis_backend
with prefixvis_backend
with prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the current log_processor is becoming more and more complex and less maintainable, are there any plans to streamline the logic?
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
time
anddata_time
by epoch during validationEnable
log_with_hierarchy
inLogProcessor
original layout:
hierarchy layout
As you can see, logs are divided into
train
andval
, and the averagedtime
,data_time
during validation is counted.Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist