Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support writing data to vis_backend with prefix #972

Merged
merged 18 commits into from
Mar 13, 2023

Conversation

HAOCHENYE
Copy link
Collaborator

@HAOCHENYE HAOCHENYE commented Feb 28, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  1. Support log information to various backends(Tensorboard, WandB) with hierarchy
  2. Count averaged time and data_time by epoch during validation

Enable log_with_hierarchy in LogProcessor

log_processor = dict(
    log_with_hierarchy=False
)

original layout:
image

hierarchy layout

image

As you can see, logs are divided into train and val, and the averaged time, data_time during validation is counted.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@7e1b273). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head a51eb51 differs from pull request most recent head 8defb2e. Consider uploading reports for the commit 8defb2e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage        ?   76.63%           
=======================================
  Files           ?      139           
  Lines           ?    10993           
  Branches        ?     2202           
=======================================
  Hits            ?     8425           
  Misses          ?     2203           
  Partials        ?      365           
Flag Coverage Δ
unittests 76.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HAOCHENYE HAOCHENYE marked this pull request as ready for review February 28, 2023 18:49
@HAOCHENYE HAOCHENYE changed the title [Draft] Support writing data to vis_backend with prefix [Enhance] Support writing data to vis_backend with prefix Feb 28, 2023
@HAOCHENYE HAOCHENYE requested a review from RangiLyu March 6, 2023 09:52
@zhouzaida zhouzaida added this to the 0.7.0 milestone Mar 6, 2023
Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the current log_processor is becoming more and more complex and less maintainable, are there any plans to streamline the logic?

zhouzaida
zhouzaida previously approved these changes Mar 9, 2023
RangiLyu
RangiLyu previously approved these changes Mar 10, 2023
@HAOCHENYE HAOCHENYE dismissed stale reviews from RangiLyu and zhouzaida via 8defb2e March 13, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants